Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkML scheme should have min/max values as integers rather than string representation of integers #437

Closed
ddooley opened this issue Jun 14, 2024 · 2 comments

Comments

@ddooley
Copy link
Collaborator

ddooley commented Jun 14, 2024

linkml-validate code fails right now if schema has "1234" string numbers, rather than 1234 numbers directly, i.e. a DH schema with

minimum_value: "0"
maximum_value: "130"

whereas this succeeds:

minimum_value: 0
maximum_value: 130

So a small fix to DH tabular_to_schema.py achieves this.

@ddooley ddooley changed the title Adjusting DataHarmonizer schemes to have minimum and maximum values as integers rather than string representation of integers LinkML scheme should have min/max values as integers rather than string representation of integers Jun 14, 2024
@ddooley
Copy link
Collaborator Author

ddooley commented Jun 16, 2024

However, currently numeric fields are being saved as strings. For validation to work, we have to ensure numeric values are saved as unquoted values.

@ddooley
Copy link
Collaborator Author

ddooley commented Sep 6, 2024

This is now resolved in tabular_to_schema.py

@ddooley ddooley closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant