Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select groups modal loads slowly for large datasets #177

Closed
ivansg44 opened this issue Sep 1, 2023 · 3 comments · Fixed by #208
Closed

Select groups modal loads slowly for large datasets #177

ivansg44 opened this issue Sep 1, 2023 · 3 comments · Fixed by #208
Labels
high priority visualization

Comments

@ivansg44
Copy link
Collaborator

ivansg44 commented Sep 1, 2023

No description provided.

@ivansg44 ivansg44 changed the title Make select lineages modal open faster Pre-load modal when data is updated May 1, 2024
@ivansg44
Copy link
Collaborator Author

ivansg44 commented May 1, 2024

Instead of dynamically generating the modal content whenever the user opens the modal, we should pre-load the modal content exactly once when the data is updated. This will significantly reduce modal load times.

@ivansg44 ivansg44 changed the title Pre-load modal when data is updated Pre-load select lineages modal when data is updated May 27, 2024
@ivansg44 ivansg44 mentioned this issue Jun 12, 2024
Merged
@ivansg44 ivansg44 changed the title Pre-load select lineages modal when data is updated Select groups modal loads slowly for large datasets Jun 14, 2024
@ivansg44
Copy link
Collaborator Author

Upon further testing, the clientside function makeSelectLineagesModalCheckboxesDraggable also slows things down considerably with large datasets.

@ivansg44
Copy link
Collaborator Author

Upon further testing, the clientside function makeSelectLineagesModalCheckboxesDraggable also slows things down considerably with large datasets.

Narrowed it down to the sortable() call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change select groups modal loading behaviour cidgoh/VIRUS-MVP
1 participant
@ivansg44