Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: use latest stable cilium-cli release #16892

Merged
merged 1 commit into from
Jul 18, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Jul 15, 2021

Use the stable.txt file in the cilium-cli repo to always fetch the
latest stable release.

@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. needs-backport/1.10 labels Jul 15, 2021
@tklauser tklauser requested review from a team as code owners July 15, 2021 08:51
@tklauser tklauser requested review from nebril and pchaigno July 15, 2021 08:51
@tklauser tklauser added the dont-merge/preview-only Only for preview or testing, don't merge it. label Jul 15, 2021
@tklauser tklauser marked this pull request as draft July 15, 2021 09:56
@tklauser tklauser force-pushed the pr/tklauser/bump-cilium-cli-0.8.5 branch from f2706c1 to 97f47ad Compare July 16, 2021 07:15
@tklauser tklauser changed the title .github/workflows: bump cilium-cli to v0.8.5 .github/workflows: use latest stable cilium-cli release Jul 16, 2021
@tklauser tklauser requested a review from rolinh July 16, 2021 07:16
@tklauser tklauser force-pushed the pr/tklauser/bump-cilium-cli-0.8.5 branch from 97f47ad to 88f8aef Compare July 16, 2021 07:27
Use the stable.txt file in the cilium-cli repo to always fetch the
latest stable release.

Suggested-by: Robin Hahling <robin.hahling@gw-computing.net>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser removed the dont-merge/preview-only Only for preview or testing, don't merge it. label Jul 16, 2021
@tklauser tklauser marked this pull request as ready for review July 16, 2021 08:08
@tklauser tklauser force-pushed the pr/tklauser/bump-cilium-cli-0.8.5 branch from 88f8aef to 5036435 Compare July 16, 2021 08:09
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aanm aanm merged commit 6ccec3e into master Jul 18, 2021
@aanm aanm deleted the pr/tklauser/bump-cilium-cli-0.8.5 branch July 18, 2021 01:12
nbusseneau added a commit that referenced this pull request Aug 11, 2021
In #16892, we switched from pinning CLI version in workflows to using
the latest stable version automatically. This can cause issues if a new
release does not play nice with the set of environments tested by the
workflows on `cilium/cilium`.

We are reverting to pinning CLI version so as to have better control
over the test environment, and avoid new CLI releases negatively
impacting `cilium/cilium` workflows immediately upon release.

With the CLI version pinned, any issues with the new version will be
detected in the PR bumping the pinned version, allowing us to fix them
prior to merging.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
ti-mo pushed a commit that referenced this pull request Aug 13, 2021
In #16892, we switched from pinning CLI version in workflows to using
the latest stable version automatically. This can cause issues if a new
release does not play nice with the set of environments tested by the
workflows on `cilium/cilium`.

We are reverting to pinning CLI version so as to have better control
over the test environment, and avoid new CLI releases negatively
impacting `cilium/cilium` workflows immediately upon release.

With the CLI version pinned, any issues with the new version will be
detected in the PR bumping the pinned version, allowing us to fix them
prior to merging.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
kaworu pushed a commit to kaworu/cilium that referenced this pull request Sep 27, 2021
[ upstream commit 2202dae ]

In cilium#16892, we switched from pinning CLI version in workflows to using
the latest stable version automatically. This can cause issues if a new
release does not play nice with the set of environments tested by the
workflows on `cilium/cilium`.

We are reverting to pinning CLI version so as to have better control
over the test environment, and avoid new CLI releases negatively
impacting `cilium/cilium` workflows immediately upon release.

With the CLI version pinned, any issues with the new version will be
detected in the PR bumping the pinned version, allowing us to fix them
prior to merging.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
jibi pushed a commit that referenced this pull request Sep 29, 2021
[ upstream commit 2202dae ]

In #16892, we switched from pinning CLI version in workflows to using
the latest stable version automatically. This can cause issues if a new
release does not play nice with the set of environments tested by the
workflows on `cilium/cilium`.

We are reverting to pinning CLI version so as to have better control
over the test environment, and avoid new CLI releases negatively
impacting `cilium/cilium` workflows immediately upon release.

With the CLI version pinned, any issues with the new version will be
detected in the PR bumping the pinned version, allowing us to fix them
prior to merging.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
krishgobinath pushed a commit to krishgobinath/cilium that referenced this pull request Oct 20, 2021
In cilium#16892, we switched from pinning CLI version in workflows to using
the latest stable version automatically. This can cause issues if a new
release does not play nice with the set of environments tested by the
workflows on `cilium/cilium`.

We are reverting to pinning CLI version so as to have better control
over the test environment, and avoid new CLI releases negatively
impacting `cilium/cilium` workflows immediately upon release.

With the CLI version pinned, any issues with the new version will be
detected in the PR bumping the pinned version, allowing us to fix them
prior to merging.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants