Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to Go modules #50

Closed
rolinh opened this issue Jan 14, 2020 · 3 comments · Fixed by #67
Closed

migrate to Go modules #50

rolinh opened this issue Jan 14, 2020 · 3 comments · Fixed by #67
Assignees
@rolinh
Labels
kind/enhancement This would improve or streamline existing functionality.

Comments

@rolinh
Copy link
Member

rolinh commented Jan 14, 2020

Cilium already migrated to Go modules (see cilium/cilium#8719). Hubble should also migrate from dep to go mod for dependency management.
@rolinh rolinh added the kind/enhancement This would improve or streamline existing functionality. label Jan 14, 2020
@rolinh rolinh self-assigned this Jan 14, 2020
@rolinh
Copy link
Member Author

rolinh commented Jan 22, 2020

Currently, one cannot "go get" cilium which prevents migrating to go mod. I need to investigate this further.

$ go version
go version go1.13.6 linux/amd64
$ go get -u github.com/cilium/cilium
go: github.com/cilium/cilium@v1.7.0-rc2 requires
        github.com/optiopay/kafka@v0.0.0-20180809090225-01ce283b732b: invalid version: unknown revision 01ce283b732b

@rolinh rolinh mentioned this issue Jan 28, 2020
Merged
@bobcob7
Copy link

bobcob7 commented Nov 7, 2020

I cannot seem to 'go get' this.

$ go version
go version go1.15.4 linux/amd64
$ go get -u github.com/cilium/cilium
go: github.com/cilium/cilium upgrade => v1.8.5
go get: github.com/cilium/cilium@v1.8.5 requires
        github.com/optiopay/kafka@v0.0.0-00010101000000-000000000000: invalid version: unknown revision 000000000000

Perhaps this can be resolved by changing the replace entry to v1.5.0 in go.mod.

@bobcob7
Copy link

bobcob7 commented Nov 7, 2020

In case anyone else runs into this, I found that my issue was caused by the lack of git in my path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolinh rolinh

Labels
kind/enhancement This would improve or streamline existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vendor: migrate to go-mod cilium/hubble
2 participants
@rolinh @bobcob7