Backport #333 #349
Merged
Backport #333 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmay
reviewed
Dec 19, 2022
circe-yaml-common/src/main/scala/io/circe/yaml/common/Parser.scala
Outdated
Show resolved
Hide resolved
jeffmay
reviewed
Dec 19, 2022
Comment on lines
99
to
102
| val defaultMaxAliasesForCollections: Int = 50 // to prevent YAML at | ||
| // https://en.wikipedia.org/wiki/Billion_laughs_attack | ||
| val defaultNestingDepthLimit: Int = 50 | ||
| val defaultCodePointLimit: Int = 3 * 1024 * 1024 // 3MB |
There was a problem hiding this comment.
This is a breaking change. Maybe we can use def to point to the new location with a @deprecated annotation?
There was a problem hiding this comment.
Is it? MiMa seems to be happy. Wasn't this code merged only after last release of circe-yaml?
I don't mind doing it the way you suggest, but maybe we don't need to worry about my change, since it's not actually breaking anything.
jeffmay
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#333
/cc @lucaviolanti