Implement googlepay button #173
Conversation
huaweigu
requested review from
kristinfritsch and
antiv0
and removed request for
kristinfritsch
| onClick: this.onGooglePayButtonClicked, | ||
| allowedPaymentMethods: [ | ||
| { | ||
| type: 'CARD', |
There was a problem hiding this comment.
nit: (to my memory)
when i did these hardcoded config values i extracted it in separate config object, so later you have it one place
like you don't allow amex below, maybe you want to change that, maybe you want to change auth methods, having in one place
| apiVersion: 2, | ||
| apiVersionMinor: 0, | ||
| merchantInfo: { | ||
| merchantId: '12345678901234567890', |
There was a problem hiding this comment.
I think we would want it to be real merchant id and name for stg/prod, will we store them in ssm in next PR?
There was a problem hiding this comment.
Yes, will store the merchant values and Checkout details in SSM for next PR
There was a problem hiding this comment.
// just for Eliza, just in case when doing next steps, secrets go to kubernetes db (which is likely etcd), not in aws ssm
There was a problem hiding this comment.
curious on where/what the local secret is stored?
There was a problem hiding this comment.
this is public repo, in private repo deployment is defined
There was a problem hiding this comment.
I was wrong, it should live in K8S secrets for sample apple private
| type: 'PAYMENT_GATEWAY', | ||
| parameters: { | ||
| gateway: 'checkoutltd', | ||
| gatewayMerchantId: 'YOUR_PUBLIC_KEY', |
There was a problem hiding this comment.
okay I think we can put it in SSM as well
| currencyCode: 'USD', | ||
| countryCode: 'US', | ||
| totalPriceStatus: 'FINAL', | ||
| totalPrice: '12.00', |
There was a problem hiding this comment.
hmm, will we remove this hardcoded value in next PR?
There was a problem hiding this comment.
Yes, will be removing or moving all hardcoded values in the next PR, just had them here for testing purposes for now
| .then(function (response: IsReadyToPayResponse) { | ||
| if (response.result) { | ||
| const button = paymentsClient.createButton(buttonOptions) | ||
| document.getElementById('google-pay-button')?.append(button) |
There was a problem hiding this comment.
nit: nowhere else in this codebase is DOM manipulated
somebody with good experience in our frontend stack could likely propose a way to do this that is in line with rest of codebase
like usage of Vue's v-if/v-on.. (i haven't dealt here with rendering of elements once promises resolve to know, but it seems to me somebody frontend should check it out)
| const payload = { | ||
| type, | ||
| tokenData, | ||
| idempotencyKey: '394dffd9-e992-4b86-b3f3-0a242a44db48', |
There was a problem hiding this comment.
why not have this be randomly generated in this PR ?
|
Do you mind linking the story in the PR title? Thanks! |
|
This is public repo, no internal info gets associated with this repo |
This PR implements the following:
Note: this is only initial implementation of the google pay button - there are some hard coded values in the googlePay lib in this PR that will be removed/moved to SSM in subsequent PRs
Sandbox/Smokebox:
Stg/Prod:
