New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paymenttokens page cleanup #196

Merged

huaweigu merged 2 commits into circlefin:master from elizalucas:paymenttokens-page-cleanup

Mar 15, 2022

Contributor

elizalucas commented Mar 15, 2022

This PR:

renames convertTokens page to paymenttokens to be consistent with the API endpoint name
removes page with e2e apple pay button (no longer necessary now that it's implemented on paymenttokens page
changes line item type for apple pay to a dropdown

elizalucas added 2 commits

March 15, 2022 15:24


          make lineItemType a dropdown field

6deed18


          remove old applepay page and rename convertTokens to paymenttokens

d2b8986

huaweigu approved these changes

View reviewed changes

huaweigu merged commit 5cdcde2 into circlefin:master

elizalucas deleted the paymenttokens-page-cleanup branch

March 22, 2022 15:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet