Sample App Audit #249
Merged
Sample App Audit #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to POST senAccounts/create
…ersaud/payments-sample-app into BRAAV-10776-sample-app-audit
elizalucas
previously approved these changes
Jul 25, 2022
| @@ -6,7 +6,6 @@ | |||
| <v-text-field v-model="formData.amount" label="Amount" /> | |||
|
|
|||
| <v-select | |||
| v-if="formData.destinationType == 'sen'" | |||
| v-model="formData.currency" | |||
| :items="currencyTypes" | |||
There was a problem hiding this comment.
We have both EUR and USD here right?
There was a problem hiding this comment.
yes at line 83: currencyTypes = ['USD', 'EUR']
feirantonyhu
previously approved these changes
Jul 25, 2022
anil-gangapersaud
dismissed stale reviews from feirantonyhu and elizalucas
via
5199111
anil-gangapersaud
requested review from
timmy-circle,
elizalucas and
feirantonyhu
feirantonyhu
approved these changes
Jul 25, 2022
elizalucas
approved these changes
Jul 25, 2022
timmy-circle
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audited the following endpoints: