Updating the idempotency key in refund APIs #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterXen
requested changes
Apr 13, 2020
pages/debug/payments/refund.vue
Outdated
| @@ -86,7 +81,7 @@ export default class RefundPaymentClass extends Vue { | |||
| } | |||
|
|
|||
| const payload: RefundPaymentPayload = { | |||
| idempotencyKey: this.formData.idempotencyKey, | |||
| idempotencyKey: uuidv4(), | |||
There was a problem hiding this comment.
This is not a safe idempotency value: it's not generated based on the request values so each request is guaranteed to be unique.
Instead, these idempotency values should be "stable" across a single request type so that we can catch out duplicate submissions. Two options:
- We can leave the functionality as-is (user input)
- We can remove the user-input and generate a input-based key
There was a problem hiding this comment.
Yeah. Thank you for the feedback @MasterXen . I will make both the idempotency key to be user input
kristinfritsch
approved these changes
Apr 14, 2020
kristinfritsch
approved these changes
Apr 14, 2020
MasterXen
approved these changes
Apr 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idempotencykey was an input in the refund APIs in merchant and market place API. This has been updated to be auto generated by the application as done in the cancel payments API