Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding wallets filter in fetch transfers API #49

Merged

Conversation

tarunkumar2
Copy link
Contributor

The fetch transfers API not supports filtering by walletId. Adding this param in the fetch Transfers API

@MasterXen
Copy link
Contributor

LGTM, any idea why the test is failing?

@tarunkumar2
Copy link
Contributor Author

tarunkumar2 commented Jun 10, 2020

@MasterXen I missed to update the tests for the refund and cancel modal. Since I have made the reason to be a required param, the tests are failing. Fixing the tests now
Sorry posted the comment for wrong PR

@tarunkumar2
Copy link
Contributor Author

tarunkumar2 commented Jun 10, 2020

The sample app requires the tests to be run again since the github repo was not recognized. Retrying the tests again fixes the problem

@kristinfritsch kristinfritsch merged commit 49a33ab into circlefin:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants