Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the create fiat account API #55

Merged
merged 3 commits into from
Jun 23, 2020

Conversation

tarunkumar2
Copy link
Contributor

The sample app doesn't have the function to create wire account. Adding the create wire account API with a sample mock data
Screen Shot 2020-06-18 at 4 18 13 PM

@tarunkumar2 tarunkumar2 mentioned this pull request Jun 19, 2020
Copy link
Contributor

@kristinfritsch kristinfritsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments.

lib/accountsTestData.ts Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
layouts/default.vue Outdated Show resolved Hide resolved
@kristinfritsch
Copy link
Contributor

Are you also adding the GET endpoint for wires?

layouts/default.vue Outdated Show resolved Hide resolved
pages/debug/wires/details.vue Outdated Show resolved Hide resolved
@kristinfritsch kristinfritsch merged commit 02f8e7a into circlefin:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants