[Untracked] Add walletId & remove beneficiaryName to wire creation page #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-circle
commented
Sep 18, 2020
lib/wiresTestData.ts
Outdated
| @@ -2,7 +2,7 @@ export const exampleWireAccounts = [ | |||
| { | |||
| title: 'US Bank Account', | |||
| formData: { | |||
| beneficiaryName: 'Satoshi Nakamoto', | |||
| walletId: 'TO BE CHANGED', | |||
There was a problem hiding this comment.
@MasterXen Do you think this is sufficient? User will need it put in their walletId.
There was a problem hiding this comment.
Hmm, I think we should either leave it blank (for the user to fill out) or prefill with the master wallet ID for the supplied key.
I assume that TO BE CHANGED is a note to the user of the app rather than a note to you, right?
There was a problem hiding this comment.
okie. Updated a little big. I have the default as null and annotated the field with notNull. That way when user pre-fill the form, it'll directly give out a warning.
timmy-circle
changed the title
MasterXen
reviewed
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WalletIdwill be a necessary field once we merge in the support for push payment wire linking. This will be used to support where the end-user/merchant want to deposit their money to.beneficiaryNamefield.Result Page should look like this:
