Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose business account APIs #81

Merged
merged 29 commits into from
Oct 10, 2020
Merged

Expose business account APIs #81

merged 29 commits into from
Oct 10, 2020

Conversation

alandn-circle
Copy link
Contributor

Expose business account APIs to the front-end.

jcantwell and others added 18 commits September 21, 2020 14:39
@jcantwell
Add page to trigger creation of an incoming wire
b51324c 
Also made some changes to the chargeback mock endpoint to be consistent
with paths used for mock
@jcantwell
Fix import path
cb89cb6
@jcantwell
Use correct lifecycle hook for adding mock endpoints
2ea6f91
@jcantwell
fix compiliation errors
1cce939
@jcantwell
Fix lint errors
10780fe
@alandn-circle
add bank account endpoints for biz acct API
bddc7e0
@alandn-circle
add transfer endpoints in bizacct api
163e343
@alandn-circle
refactor biz acct library, add balance endpoint to biz acct API
fb157b4
@alandn-circle
implement biz acct plugins
1555855
@alandn-circle
add bankAccountsApi pages
3b30968
@alandn-circle
implement transfers pages
aeeaee0
@alandn-circle
implement deposit addresses pages
cf4760b
@alandn-circle
implement balances and recipient address pages
ae212eb
@alandn-circle
fix syntax errors, implement payouts endpoint
04c18c0
@alandn-circle
Merge branch 'master' into expose-apis
81a7fbf
@alandn-circle
update branch
a4afd26
@alandn-circle
update master
ef8ea0d
@alandn-circle
remove merged file: incomingWire
000e807
@alandn-circle
Copy link
Contributor Author

forgot to expose wire instructions, will be completed in next commit

@alandn-circle
Copy link
Contributor Author

I'm unsure how to place business account API endpoints in debug/index since it's an entirely different entity than payments/marketplace/wallets APIs. I also noticed that wallet APIs don't appear in debug/index as well. Would this mean that I don't include the business account API endpoints in that same page as well?

@kristinfritsch
Copy link
Contributor

kristinfritsch commented Oct 6, 2020 •
edited
Loading

I don't see Business Accounts Apis in the nav.

Screen Shot 2020-10-06 at 19 25 00

I'm unsure how to place business account API endpoints in debug/index since it's an entirely different entity than payments/marketplace/wallets APIs. I also noticed that wallet APIs don't appear in debug/index as well. Would this mean that I don't include the business account API endpoints in that same page as well?

Business Accounts should have their own debug/index similar to https://github.com/circlefin/payments-sample-app/blob/master/pages/debug/wallets/index.vue

@kristinfritsch
Copy link
Contributor

There are a few eslint errors, that's why the PR builder is failing

MasterXen
MasterXen reviewed Oct 7, 2020
View reviewed changes
layouts/default.vue Outdated Show resolved Hide resolved
@MasterXen MasterXen merged commit bf894f0 into circlefin:master Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterXen MasterXen MasterXen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alandn-circle @kristinfritsch @MasterXen @jcantwell