Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite function declaration to follow convention #259

Closed
eztierney opened this issue Jan 11, 2019 · 1 comment
Closed

Rewrite function declaration to follow convention #259

eztierney opened this issue Jan 11, 2019 · 1 comment
Assignees
@walkerq
Labels
multi-issuer Issues related to the multi-issuer branch

Comments

@eztierney
Copy link
Contributor

Repeatedly in the code (Controller.sol lines 56, 66; MintController.sol lines 60, 71, 80, 92), the public keyword appears after the custom modifiers. According to the Solidity docs on Function declaration, however, “The visibility modifier for a function should come before other modifiers”.
@eztierney eztierney added the multi-issuer Issues related to the multi-issuer branch label Jan 11, 2019
@walkerq
Copy link
Contributor

walkerq commented Jan 25, 2019

Addressed by #243.

@walkerq walkerq closed this as completed Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@walkerq walkerq

Labels
multi-issuer Issues related to the multi-issuer branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eztierney @walkerq