Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to decrement an allowance without reconfiguring minter #268

Closed
eztierney opened this issue Jan 11, 2019 · 0 comments
Closed

No way to decrement an allowance without reconfiguring minter #268

eztierney opened this issue Jan 11, 2019 · 0 comments
Assignees
Labels
multi-issuer Issues related to the multi-issuer branch

Comments

@eztierney
Copy link
Contributor

No way to decrement an allowance without reconfiguring minterThe MintController contract provides a mechanism to increment a minter's allowance that only works if the minter is active, thus preventing the accidental reactivation of inactive minters, and, as described in the inline documentation, the usage of a signed transaction to reactivate a minter. This mechanism is implemented in the incrementMinterAllowance function, which in turn calls minterManager.isMinter to perform the required check.

The contract, however, provides no analogous mechanism for decreasing a minter's allowance, meaning that this can only be achieved by “resetting” the minter through the configureMinter function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-issuer Issues related to the multi-issuer branch
Projects
None yet
Development

No branches or pull requests

3 participants