Messages starboarded with spoilered links posts unspoilered embed

[row454]

See title. Could either not post an embed, or if possible, post a spoilered embed.

[circuitsacul]

Could you provide a screenshot, as an example?

[row454]

Here's the original message:

Here's the starboard:

[circuitsacul]

Alright, thanks for the report.

I know why this is happening, but I'm not really working on the bot anymore, so I probably won't get around to it. But for future reference (and in case anyone else wants to fix it):

The reason this happens is because the Discord client treats embeds generated from spoilered links as spoilered, but that information is client-side (not server-side). This means that bots have to calculate this themselves.

If any spoilered link exists in the message, all embeds are spoilered:

So, starboard needs to check if there are any spoilered links (probably via a regex). If is, there's a few options:

1. add || https://not.a.website || (or something similar) to the plain message content. This will spoiler every embed in the post, which also includes any previously unspoilered message content.
2. Don't attach the embed, but treat it as a spoilered attachment. There's existing logic to handle image-only embeds, which would work here. The image would be uploaded separately, but only in premium servers. Otherwise, it would just be listed in the attachments list.
3. Upload the embed as normal, but manually spoiler the content, and replace images with spoilered masked links (or upload the images separately.

None of these options really appeal to me, honestly, but I wouldn't be opposed to an option.

Like I said though, I probably won't ever get around to this. And if I do ever come back to the bot, there are a lot of other things that would take priority over this.

That said, if someone opens a PR for this, I'll be happy to review and merge.