Skip to content
This repository has been archived by the owner on May 8, 2024. It is now read-only.

Separate CIRRUS_CLONE_DIR from CIRRUS_WORKING_DIR #106

Open
fkorotkov opened this issue Jun 13, 2019 · 1 comment
Open

Separate CIRRUS_CLONE_DIR from CIRRUS_WORKING_DIR #106

fkorotkov opened this issue Jun 13, 2019 · 1 comment

Comments

@fkorotkov
Copy link
Contributor

Description

It will be nice to support $CIRRUS_CLONE_DIR separate from $CIRRUS_WORKING_DIR

Context

Useful for better task syntax for monorepo projects (for example, when there are two folders frontend and backend in the same repo and each of then needs a separate task).

Anything Else

Ideally it should've been there from the beginning and then $CIRRUS_WORKING_DIR would've be equal to $CIRRUS_CLONE_DIR by default.

For backward compatibility though, we should default $CIRRUS_CLONE_DIR to $CIRRUS_WORKING_DIR. In this case this syntax won't be possible:

env:
  CIRRUS_WORKING_DIR: $CIRRUS_CLONE_DIR/frontend

because people will need explicitly specify $CIRRUS_CLONE_DIR:

env:
  CIRRUS_CLONE_DIR: /tmp/build
  CIRRUS_WORKING_DIR: $CIRRUS_CLONE_DIR/frontend

Note: to support first case though we can be a little smart and check that user didn't provide $CIRRUS_CLONE_DIR but used it for $CIRRUS_WORKING_DIR therefore it should be defaulted to /tmp/cirrus-ci-build. But IMHO it's smells like magic and we don't like magic.

@RDIL
Copy link
Contributor

RDIL commented Jun 14, 2019

This would be quite handy for my monorepo project.

@fkorotkov fkorotkov transferred this issue from cirruslabs/cirrus-ci-docs Feb 23, 2021
fkorotkov added a commit that referenced this issue Apr 19, 2021
@edigaryev edigaryev removed their assignment Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants