Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: emit warnings on non-existent YAML configuration keys #581

Open
edigaryev opened this issue Nov 9, 2022 · 1 comment
Open

Parser: emit warnings on non-existent YAML configuration keys #581

edigaryev opened this issue Nov 9, 2022 · 1 comment
Assignees
@edigaryev

Comments

@edigaryev
Copy link
Contributor

To avoid things like cirruslabs/cirrus-ci-docs#1043.
@edigaryev edigaryev self-assigned this Nov 9, 2022
@edigaryev edigaryev changed the title Parser: emit warning on non-existent YAML configuration keys Parser: emit warnings on non-existent YAML configuration keys Nov 9, 2022
@edigaryev
Copy link
Contributor Author

Took a look at this, and it seems that some refactoring will be needed first to pack this change in a concise PR.

Namely, we have two places where a virtual *node.Node is emitted:

  • collectible fields
  • YAML anchors

We need to ensure a 1-to-1 mapping between *node.Node and yaml.Node somehow, otherwise used/unused node bookkeeping becomes very hard go grasp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edigaryev edigaryev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edigaryev