Add mime type to google-storage-proxy to support http responses #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds MIME type support to the HTTP responses for the google-storage-proxy by setting the
Content-Typeheader based on the file's MIME type. This improves content rending.@fkorotkov @edigaryev Thank you for reviewing this pull request!
Changes
Implemented MIME type detection using the
mimepackage in Go. The MIME type is determined based on the file extension.Added logic to set the
Content-Typeheader in HTTP responses within thedownloadBlobfunction.If the MIME type cannot be determined, it defaults to
application/octet-stream.Testing
Before:
After:
