Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CodeQL badge and remove LGTM badges from the README #115

Merged
merged 2 commits into from
Jan 7, 2023

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Jan 5, 2023

🗣 Description

This pull request adds a CodeQL badge and removes the LGTM badges from the project README.

💭 Motivation and context

When the CodeQL workflow was updated in #98 we missed that no badge was in the README. The LGTM badges are removed because GitHub has deprecated LGTM (after acquiring it) and we have removed the integration from the organization.

🧪 Testing

Automated tests will pass once the updates from #110 and #114 are merged.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use labels Jan 5, 2023
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner January 5, 2023 19:55
@mcdonnnj mcdonnnj self-assigned this Jan 5, 2023
@mcdonnnj mcdonnnj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jan 5, 2023
mcdonnnj added a commit that referenced this pull request Jan 7, 2023
…s/setup-python-4

Bump actions/setup-python from 3 to 4
Now that LGTM has been deprecated in favor of GitHub code scanning
(CodeQL) we have removed the integration from the organization. As a
result we need to remove these badges.
@mcdonnnj mcdonnnj force-pushed the improvement/update_codeql_workflow branch from a2e02de to fa30ebb Compare January 7, 2023 20:06
@mcdonnnj mcdonnnj merged commit ec639ea into develop Jan 7, 2023
@mcdonnnj mcdonnnj deleted the improvement/update_codeql_workflow branch January 7, 2023 20:10
@mcdonnnj mcdonnnj linked an issue Jan 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request documentation This issue or pull request improves or adds to documentation improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update LGTM shields to CodeQL
3 participants