Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action/upload-artifact Version #50

Merged
merged 2 commits into from
Sep 6, 2020

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Sep 4, 2020

🗣 Description

Update the actions/upload-artifact version we use to @v2.

💭 Motivation and Context

It's good to keep up-to-date with packages/tools we use. This version adds support for uploading a single file or wildcard pattern which may be of use to derived projects.

🧪 Testing

Automated tests pass.

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mcdonnnj mcdonnnj self-assigned this Sep 4, 2020
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have 🦅 👀 my friend!

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! 🔎

@mcdonnnj mcdonnnj closed this in 3e9441c Sep 6, 2020
@mcdonnnj mcdonnnj reopened this Sep 6, 2020
@mcdonnnj
Copy link
Member Author

mcdonnnj commented Sep 6, 2020

Closing language resulted in an inadvertent closure of this PR.

@mcdonnnj mcdonnnj merged commit a5378b0 into develop Sep 6, 2020
@mcdonnnj mcdonnnj deleted the update_upload-artifact_action branch September 6, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants