Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze grpcio for stability. #55

Open
miott opened this issue May 20, 2020 · 3 comments
Open

Freeze grpcio for stability. #55

miott opened this issue May 20, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request ergonomics

Comments

@miott
Copy link
Collaborator

miott commented May 20, 2020

Let's pin grpcio to a specific version in setup.py. We can monitor it for important fixes or new features and then upgrade after analysis of backward compatibility and stability.

@remingtonc remingtonc added enhancement New feature or request ergonomics labels May 20, 2020
@remingtonc remingtonc self-assigned this May 27, 2020
@remingtonc
Copy link
Contributor

Addressing in pin-grpc.

@remingtonc
Copy link
Contributor

A potential thought - I have heard that "libraries" generally shouldn't pin dependencies. The applications should pin the dependencies. This is why none of the library dependencies are pinned. Do you agree with this philosophy? Legitimately don't have a full opinion.

@miott
Copy link
Collaborator Author

miott commented May 27, 2020

Not sure what this is referring to but where do you draw the line between a "library" and an "application"?

Have seen it cause issues and save headaches. What many have ended up doing was using >= the version you know works and < the next major version. If the author is following basic versioning semantics, a major version change means something from the previous version will not work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ergonomics
Projects
None yet
Development

No branches or pull requests

2 participants