Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sass v1.77.8 #781

Closed
vdineva opened this issue Jul 16, 2024 · 5 comments · Fixed by #782
Closed

Add support for sass v1.77.8 #781

vdineva opened this issue Jul 16, 2024 · 5 comments · Fixed by #782
Assignees
@rwharrisjr
Labels
v2.3.9

Comments

@vdineva
Copy link

vdineva commented Jul 16, 2024 •
edited
Loading

We'd like to upgrade to the latest version of sass - v1.77.8 but we're getting a lot of warning coming from the magna-react package:

Dashboard Page -- Labels and values -- should assign label to devices (failed)
@androche
Copy link
Collaborator

@vdineva this appears to be an issue with the latest sass release - After some research, can you try
npm i sass@1.77.6 --save-exact in your project as this has worked for some. I also ran the sass 1.77.8 upgrade locally and didn't get any warnings, but we'll continue to help debug if your team doesn't find solutions!

Similar issue as of 3 days ago: twbs/bootstrap#40621

@rwharrisjr
Copy link
Contributor

Seems like we should be able to move the @include statements below the last css property in a group and resolve the issue in magna.

@rwharrisjr rwharrisjr mentioned this issue Jul 16, 2024
Merged
@rwharrisjr
Copy link
Contributor

#782 resolves the warnings in my dev env

@rwharrisjr rwharrisjr self-assigned this Jul 16, 2024
@androche androche reopened this Aug 20, 2024
@androche
Copy link
Collaborator

Screenshot 2024-08-20 at 4 19 35 PM
More warnings were found ^

@androche
Copy link
Collaborator

Fixed in: #843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwharrisjr rwharrisjr

Labels
v2.3.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move css rules to resolve deprecation warnings in ordering cisco-sbg-ui/magna-react
3 participants
@vdineva @rwharrisjr @androche