Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inputs are the wrong height due to assumed box-sizing: border-box #265

Closed
pixelbandito opened this issue Aug 26, 2020 · 0 comments · Fixed by #266
Closed

Inputs are the wrong height due to assumed box-sizing: border-box #265

pixelbandito opened this issue Aug 26, 2020 · 0 comments · Fixed by #266
Assignees
@pixelbandito
Labels
bug Something isn't working

Comments

@pixelbandito
Copy link
Contributor

When you use a RoverUI Input in an app that doesn't have global box-sizing: border-box CSS, they're larger than expected by 16px.

Simple fix would be to add explicit box-sizing to those components. More involved fix would be to add box-sizing reset to all RoverUI components, to fix future issues along the same lines.
@pixelbandito pixelbandito self-assigned this Aug 26, 2020
@pixelbandito pixelbandito added the bug Something isn't working label Aug 26, 2020
@pixelbandito pixelbandito mentioned this issue Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelbandito pixelbandito

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Input gets explicit box-sizing cision/rover-ui
1 participant
@pixelbandito