Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create iso690-full-note-es.csl #7061

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

POBrien333
Copy link
Contributor

@POBrien333 POBrien333 commented May 21, 2024

Closes #7059

Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😟 There are some issues with your submission.

2 tests failed

iso690-full-note-es: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[17, "17:0: ERROR: Did not expect element locale there"], [17, "17:0: ERROR: Element style has extra content: locale"], [2, "2:0: ERROR: Expecting element locale, got style"]].empty?` to be truthy, got false

iso690-full-note-es: "self" link must match the style ID

expected: "http://www.zotero.org/styles/iso690-full-note-sk"
     got: "http://www.zotero.org/styles/iso690-full-note-es"

(compared using ==)

Please check the test report for details.

Copy link

😟 There are some issues with your submission.

1 test failed

iso690-full-note-es: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[7, "7:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...Did not expect element locale there"], [17, "17:0: ERROR: Element style has extra content: locale"]].empty?` to be truthy, got false

Please check the test report for details.

Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

iso690-full-note-es.csl (new)
HANCKÉ, B., RHODES, M., THATCHER, M. eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007; CSL search by example. En Citation Style Editor [en línea] [cit. 15.12.2012]. Disponible en: http://editor.citationstyles.org/searchByExample/
MARES, I. Firms and the welfare state: When, why, and how does social policy matter to employers? En HALL, P.A., SOSKICE, D. eds. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001; FENNER, M. et al. A data citation roadmap for scholarly data repositories. En Scientific Data [en línea]. 2019, vol. 6, n.º. 1 [cit. 27.04.2019]. DOI: 10.1038/s41597-019-0031-8

CSL search by example. En Citation Style Editor [en línea] [cit. 15.12.2012]. Disponible en: http://editor.citationstyles.org/searchByExample/
FENNER, Martin et al. A data citation roadmap for scholarly data repositories. En Scientific Data [en línea]. 2019, vol. 6, n.º. 1, p. 28 [cit. 27.04.2019]. ISSN 2052-4463. DOI: 10.1038/s41597-019-0031-8
HANCKÉ, Bob, RHODES, Martin, THATCHER, Mark. eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007. ISBN 978-0-19-920648-3.
MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? En HALL, Peter A., SOSKICE, David. eds. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001, pp. 184-213

@anamulopez
Copy link

Hello I have just checked the last file uploaded, i have issues with two types of documents.
First is the conference procceedings which should be styled as the book chapters.
Secondly is the generic type, which should be styled: Surname, Name (or first letter)+ name of work+ place+ date.
Could you fix it? please?
Thank you very much for your patience

@bwiernik
Copy link
Member

@POBrien333 could you make the updates requested above ?

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 11, 2024
@POBrien333
Copy link
Contributor Author

@anamulopez
I've made some changes to fix the 2 issues. Can you check if it's all in order now?

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Sep 12, 2024
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

iso690-full-note-es.csl (new)
HANCKÉ, B., RHODES, M., THATCHER, M. eds. ; Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy; ; . Oxford and New York: Oxford University Press, 2007; ; ; CSL search by example. ; En Citation Style Editor [en línea]; ; ; [cit. 15.12.2012]; . Disponible en: http://editor.citationstyles.org/searchByExample/
MARES, I. ; Firms and the welfare state: When, why, and how does social policy matter to employers? ; En HALL, P.A., SOSKICE, D. eds. Varieties of capitalism. The institutional foundations of comparative advantage; . New York: Oxford University Press, 2001; ; ; FENNER, M. et al. ; A data citation roadmap for scholarly data repositories. ; En Scientific Data [en línea]; . 2019, vol. 6, n.º. 1; ; [cit. 27.04.2019]; . DOI: 10.1038/s41597-019-0031-8

CSL search by example. En Citation Style Editor [en línea] [cit. 15.12.2012]. Disponible en: http://editor.citationstyles.org/searchByExample/
FENNER, Martin et al. A data citation roadmap for scholarly data repositories. En Scientific Data [en línea]. 2019, vol. 6, n.º. 1, p. 28 [cit. 27.04.2019]. ISSN 2052-4463. DOI: 10.1038/s41597-019-0031-8
HANCKÉ, Bob, RHODES, Martin, THATCHER, Mark. eds. Beyond varieties of capitalism: Conflict, contradiction, and complementarities in the European economy. Oxford and New York: Oxford University Press, 2007. ISBN 978-0-19-920648-3.
MARES, Isabela. Firms and the welfare state: When, why, and how does social policy matter to employers? En HALL, Peter A., SOSKICE, David. eds. Varieties of capitalism. The institutional foundations of comparative advantage. New York: Oxford University Press, 2001, pp. 184-213

@bwiernik bwiernik merged commit 9596c80 into citation-style-language:master Oct 16, 2024
@bwiernik
Copy link
Member

merging for now

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Oct 16, 2024
@anamulopez
Copy link

Hello! Thank you for all the changes. I was checking it and I found some issues.
Also I found a pdf of an Spanish university explaining how the iso 690:2024 works (newest version)
I took it everything in account and made a pdf linked in this message with all the modifications highlighted in red (both from the issues as well as the ones from the new version). I was wondering if you could please make them.
I was also wondering if we could get the cite style ready to cite also with ibid, idem and op.cit (it is also explained in the word file).
I am also uploading the presentation of the University of Sevilla explaining everything of the new version (may be useful)
in any case I am available to answer any doubts

Thank you very much again

Modifications.pdf
citas_y_referencias_eps_2024_1.pdf

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Nov 3, 2024
@bwiernik bwiernik mentioned this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for style ISO 690 FULL NOTE SPANISH
3 participants