Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Upgrade to react-map-gl v7 and prevent scroll capture on the crash and location maps #15867

Closed
johnclary opened this issue Feb 16, 2024 · 2 comments
Closed

[Enhancement] Upgrade to react-map-gl v7 and prevent scroll capture on the crash and location maps #15867

johnclary opened this issue Feb 16, 2024 · 2 comments
Assignees
@mddilley
Labels
Product: Vision Zero Crash Data System Centralize the management of ATD's Vision Zero data Service: Dev Infrastructure and engineering Type: Enhancement Request for an improvement to existing functionality in an application Type: Snackoo 🍫 Small straightforward issues or fun bugs Workgroup: VZ Vision Zero Program

Comments

@johnclary
Copy link
Member

johnclary commented Feb 16, 2024 •
edited
Loading

It can be challenging to scroll the Crash and Location details pages, because the map captures the page scrolling by zooming the map.

It should be possible to configure the maps to require a cmd to zoom.

See the Moped project summary map for reference (although Moped uses a different version of react-map-gl):
Screenshot 2024-02-15 at 9 56 54 PM
@johnclary johnclary added Service: Dev Infrastructure and engineering Workgroup: VZ Vision Zero Program Type: Enhancement Request for an improvement to existing functionality in an application Product: Vision Zero Crash Data System Centralize the management of ATD's Vision Zero data Type: Snackoo 🍫 Small straightforward issues or fun bugs labels Feb 16, 2024
@johnclary johnclary changed the title [Enhancement] Prevent scroll capturing on the crash and location maps [Enhancement] Prevent scroll capture on the crash and location maps Feb 16, 2024
@mddilley mddilley self-assigned this Mar 7, 2024
@mddilley
Copy link

mddilley commented Mar 7, 2024 •
edited
Loading

@johnclary It looks like we would have to upgrade react-map-gl to v7.0 like we have in Moped Editor to add this. visgl/react-map-gl#1640

What do you think about turning this issue into an upgrade one? We have three maps: LocationMap, CrashMap, and CrashEditCoordsMap. Could create a path to fixing the buggy geocoder while we are at it. cityofaustin/vision-zero#1337 (comment)

@johnclary
Copy link
Member Author

What do you think about turning this issue into an upgrade one?

💯 thanks @mddilley i will update this issue. will be good to update a few class components as well 🚀

@mddilley mddilley changed the title [Enhancement] Prevent scroll capture on the crash and location maps [Enhancement] Upgrade to react-map-gl v7 and prevent scroll capture on the crash and location maps Mar 14, 2024
This was referenced Mar 14, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mddilley mddilley

Labels
Product: Vision Zero Crash Data System Centralize the management of ATD's Vision Zero data Service: Dev Infrastructure and engineering Type: Enhancement Request for an improvement to existing functionality in an application Type: Snackoo 🍫 Small straightforward issues or fun bugs Workgroup: VZ Vision Zero Program
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnclary @mddilley