Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opponent's Secret Society is always known #308

Open
Infixo opened this issue May 31, 2021 · 0 comments
Open

Opponent's Secret Society is always known #308

Infixo opened this issue May 31, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@Infixo
Copy link
Contributor

Infixo commented May 31, 2021

On the DiploScreen, there is information about opponent's Secret Society. There is a bug in the Lua code that causes it always to be known, even in the situation when we actually have not yet discovered it.

The bug is here, file DiplomacyActionView_SecretSocietyRow.lua. If the opponent has the SS, then there is a check if we are aware of it. However, wrong object is used and the game actually if the opponent is aware of if, which ofc is always true.

if eSecretSociety ~= -1 then
    local pLocalPlayer:table = Players[Game.GetLocalPlayer()];
    local pLocalPlayerGovs:table = pSelectedPlayer:GetGovernors(); -- !!! It should be pLocalPlayer:GetGovernors() !!!

    if pLocalPlayerGovs:IsAwareOfSecretSociety(eSecretSociety) then
        -- Known Secret Society
@Infixo Infixo changed the title Secret Society is always known Opponent's Secret Society is always known May 31, 2021
@the-m4a the-m4a added the bug Something isn't working label Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants