From c62772785abef28177998f7163824407f3196dce Mon Sep 17 00:00:00 2001 From: Matthew Wire Date: Fri, 19 Jan 2018 12:22:22 +0700 Subject: [PATCH] Fix divide by zero on 100% discount --- CRM/Contribute/BAO/Contribution.php | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index b4fe8f809a88..bab9b5918549 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -5687,15 +5687,17 @@ public static function getSalesTaxFinancialAccounts() { * Create tax entry in civicrm_entity_financial_trxn table. * * @param array $entityParams - * * @param array $eftParams * */ public static function createProportionalEntry($entityParams, $eftParams) { - $paid = $entityParams['line_item_amount'] * ($entityParams['trxn_total_amount'] / $entityParams['contribution_total_amount']); - // Record Entity Financial Trxn; CRM-20145 - $eftParams['amount'] = CRM_Contribute_BAO_Contribution_Utils::formatAmount($paid); - civicrm_api3('EntityFinancialTrxn', 'create', $eftParams); + $contributionTotalAmount = (float) $entityParams['contribution_total_amount']; + if (!empty($contributionTotalAmount)) { + $paid = $entityParams['line_item_amount'] * ($entityParams['trxn_total_amount'] / $entityParams['contribution_total_amount']); + // Record Entity Financial Trxn; CRM-20145 + $eftParams['amount'] = CRM_Contribute_BAO_Contribution_Utils::formatAmount($paid); + civicrm_api3('EntityFinancialTrxn', 'create', $eftParams); + } } /**