From 630b73e33a6ad4ad344802900eee618448aaff79 Mon Sep 17 00:00:00 2001
From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Thu, 16 Dec 2021 09:30:43 +1300
Subject: [PATCH] Rename protected function

This function was originally shared & hence the name made sense but in the context of dedupe
it is only used to do updates so renaming to make that clear & making required nature
of contactID clear too
---
 CRM/Dedupe/Merger.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CRM/Dedupe/Merger.php b/CRM/Dedupe/Merger.php
index 575aea756466..f73b0007c72f 100644
--- a/CRM/Dedupe/Merger.php
+++ b/CRM/Dedupe/Merger.php
@@ -683,7 +683,7 @@ protected static function getMultiValueCidRefs() {
    * @throws \CiviCRM_API3_Exception
    * @throws \Civi\API\Exception\UnauthorizedException
    */
-  protected static function createContact($contactID, $params) {
+  protected static function updateContact(int $contactID, $params): void {
     // This parameter causes blank fields to be be emptied out.
     // We can probably remove.
     $params['updateBlankLocInfo'] = TRUE;
@@ -1936,7 +1936,7 @@ public static function moveAllBelongings($mainId, $otherId, $migrationInfo, $che
       if (!isset($submitted['suffix_id']) && !empty($migrationInfo['main_details']['suffix_id'])) {
         $submitted['suffix_id'] = $migrationInfo['main_details']['suffix_id'];
       }
-      self::createContact($mainId, $submitted);
+      self::updateContact($mainId, $submitted);
     }
     $transaction->commit();
     CRM_Utils_Hook::post('merge', 'Contact', $mainId);