Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HealthCheck endpoint on CSI #19

Merged
merged 3 commits into from
Apr 18, 2024
Merged

HealthCheck endpoint on CSI #19

merged 3 commits into from
Apr 18, 2024

Conversation

RealHarshThakur
Copy link
Member

  • Implements healthcheck endpoint on CSI controller by ping civo API
  • Improve test suite

@RealHarshThakur
implement health check endpoint
8e41d14 
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
@RealHarshThakur
wqrefactor test suite to inject fake client when necessary
658f9d4 
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
[B
@RealHarshThakur
bump civogo to latest
8eac552 
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
alessandroargentieri
alessandroargentieri approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@alessandroargentieri alessandroargentieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RealHarshThakur RealHarshThakur merged commit 156539f into master Apr 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandroargentieri alessandroargentieri alessandroargentieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RealHarshThakur @alessandroargentieri