Update retry and timeout logic around Publish / Unpublish requests #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with 150+ volumes publishing / unpublishing at the same time, the current timeout logic causes grpc timeout errors to be seen by the csi-attacher process
This PR updates the timeout down to 5 seconds (from effectively 100s in waitForVolumeStatus) and hands off retry logic to the csi-attacher process.
In addition, the fixes a few logic bugs around unpublish when NodeID is passed as an arg in
NodeUnpublishVolumeRequestand set to a different node to the currently attached node. This should safely clear out dangling VolumeAttachments.