Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UplinkDwellTime not correctly applied on AU915 #55

Open
gonzabrusco opened this issue Feb 6, 2024 · 1 comment
Open

UplinkDwellTime not correctly applied on AU915 #55

gonzabrusco opened this issue Feb 6, 2024 · 1 comment

Comments

@gonzabrusco
Copy link

When the node receives the command TXParamSetupReq the network defines if the node has to limit the uplink and downlink time to 400ms (a.k.a. dwell time)

What you actually do in the current version of this library, is limit the datarate to 2 (0 and 1 do not comply with the dwell time limitation). But the function LDL_Region_convertRate does not take the dwell time into account when it should. The maximum payload allowable is dependent on the dwell time too.

image

@gonzabrusco
Copy link
Author

This is where you apply the uplink dwell:

self->tx.rate = LDL_Region_applyUplinkDwell(self->ctx.region, uplinkDwell(self->ctx.tx_param_setup), self->ctx.rate);

But you don't apply the uplink dwell limitation to the MTU:

LDL_Region_convertRate(self->ctx.region, self->ctx.rate, &sf, &bw, &maxPayload);

What I did is add another parameter to LDL_Region_convertRate to tell the function if the dwell should be applied or not. If you are interested I can make a Pull Request for you to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant