Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@session with tags=... doesn't typecheck #1219

Closed
dbohdan opened this issue Oct 16, 2023 · 1 comment · Fixed by #1220
Closed

@session with tags=... doesn't typecheck #1219

dbohdan opened this issue Oct 16, 2023 · 1 comment · Fixed by #1220

Comments

@dbohdan
Copy link

dbohdan commented Oct 16, 2023

The session decorator now takes an optional tags argument. Please update the types to reflect this.
@mariuswinger
Copy link
Contributor

Unless there are some pitfalls I am unaware of, this should just amount to adding "tags: Sequence[str] = ...," to 'sessions.pyi'.

@mariuswinger mariuswinger mentioned this issue Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add support for tags in session decorator
2 participants
@dbohdan @mariuswinger