Remove bitcode for ios?

[mzhu22]

Hi, thanks for making this library!

I used the SDK in a React Native app, working with Expo and EAS. I can successfully build the app for iOS, and make an archive. However, I cannot upload it to TestFlight/App Store because it fails validation with:

Invalid Executable. The executable 'MyApp.app/Frameworks/ConnectIQ.framework/ConnectIQ' contains bitcode.

I'm wondering if you've run into this before, and if you have any ideas for removing bitcode from the iOS code? Thanks!

[cjsmith]

Hmm. I think the quick fix would be to either run xcrun -sdk iphoneos bitcode_strip -r YOUR_EXECUTABLE or put something like this in your ios/Podfile or somehow strip out the bitcode

post_install do |installer|
     
    installer.pods_project.targets.each do |target|
      if target.name == 'ConnectIQ'
        `xcrun -sdk iphoneos bitcode_strip -r ios/Pods/ConnectIQ/ConnectIQ.xcframework/ios-arm64/ConnectIQ.framework/ConnectIQ -o ios/Pods/ConnectIQ/ConnectIQ.xcframework/ios-arm64/ConnectIQ.framework/ConnectIQ`
        `xcrun -sdk iphoneos bitcode_strip -r ios/Pods/ConnectIQ/ConnectIQ.xcframework/ios-arm64_x86_64-simulator/ConnectIQ.framework/ConnectIQ -o ios/Pods/ConnectIQ/ConnectIQ.xcframework/ios-arm64_x86_64-simulator/ConnectIQ.framework/ConnectIQ`
     end
end

I think the proper thing to do would be for me to update https://github.com/cjsmith/connectiq-companion-app-sdk-ios/blob/main/ConnectIQ.podspec. to do this in the upstream dependency.

The even more proper thing would be to get the cocoapods support merged into Garmin's official connectiq-companion-app-sdk-ios and have them do it there, or change the build settings there to not build with bitcode.

I will try do to the proper fix when I have time.

[mzhu22]

Cool, thanks for the help!