Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build issue due to TS accessor errors #138

Open
f1ames opened this issue Sep 24, 2020 · 2 comments
Open

Build issue due to TS accessor errors #138

f1ames opened this issue Sep 24, 2020 · 2 comments
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@f1ames
Copy link
Contributor

f1ames commented Sep 24, 2020

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

When building ckeditor4-docs, webpack Angular compilation (starting from 2.0.0 version) throws An accessor cannot be declared in an ambient context TS errors:

image

The lines to blame are:

set data(data: string);
get data(): string;

set readOnly(isReadOnly: boolean);
get readOnly(): boolean;

It might be reproduced on this commit ckeditor/ckeditor4-docs@d5ddece. Seems it may be related to TS issue - microsoft/TypeScript#33939

It also means, any project using Angular integration in a similar manner as CKEditor 4 docs may have similar issues.

@f1ames f1ames added status:confirmed An issue confirmed by the development team. type:bug A bug. workload:? labels Sep 24, 2020
@f1ames
Copy link
Contributor Author

f1ames commented Sep 24, 2020

The workaround could be disabling some TS checks with:

"compilerOptions": {
    "skipLibCheck": true
}

in tsconfig.json file (helped in the docs case - see ckeditor/ckeditor4-docs@4ecd6f3).

@nguacon90
Copy link

I've got the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

3 participants