Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NPM dev-only dependencies #165

Merged
merged 2 commits into from
Feb 5, 2021
Merged

Update NPM dev-only dependencies #165

merged 2 commits into from
Feb 5, 2021

Conversation

github-actions[bot]
Copy link

Updated NPM dev-only dependencies.

@github-actions
Copy link
Author

github-actions bot commented Feb 1, 2021

It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days.

@github-actions github-actions bot added the stale The issue / PR will be closed within the next 7 days of inactivity. label Feb 1, 2021
@Dumluregn Dumluregn self-requested a review February 1, 2021 14:55
@Dumluregn Dumluregn self-assigned this Feb 1, 2021
@Dumluregn Dumluregn removed the stale The issue / PR will be closed within the next 7 days of inactivity. label Feb 1, 2021
@Dumluregn Dumluregn force-pushed the deps-update_master_dev-only branch from 10205a8 to c6cb4e0 Compare February 1, 2021 15:18
@Dumluregn
Copy link
Collaborator

Angular 11.1.0 with TypeScript 4.1.0 was finally released, so we no longer have to downgrade the latter package 🎉

The problem now is that CI failed to start on IE11. I tried it locally and it worked on VM for me, so I've rebased the PR onto latest master and now I'm waiting for the CI again. It's possible that newest Karma 6.0.3 is heavier and IE11 on VM doesn't handle it, but we'll see.

@Dumluregn
Copy link
Collaborator

IE11 didn't start, so I've downgraded Karma to v5 to see what happens.

@Dumluregn
Copy link
Collaborator

CI is red because of #72 again, so I'm merging the PR. It would be good to handle this issue some day.

@Dumluregn Dumluregn merged commit 877d05a into master Feb 5, 2021
@Dumluregn Dumluregn deleted the deps-update_master_dev-only branch February 5, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dumluregn Dumluregn Awaiting requested review from Dumluregn

Assignees

@Dumluregn Dumluregn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dumluregn @CKEditorBot