Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent editor creation on detached element #4461

Closed
sculpt0r opened this issue Dec 31, 2020 · 1 comment · Fixed by #4463
Closed

Prevent editor creation on detached element #4461

sculpt0r opened this issue Dec 31, 2020 · 1 comment · Fixed by #4463
Assignees
@sculpt0r
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.17.0

Comments

@sculpt0r
Copy link
Contributor

Type of report

Feature request

Provide description of the new feature

Prevent editor creation while targeting element is detached from DOM.
Also, we could add tracking, whenever the element will be attached - then the editor will be automatically created.

Some frameworks may 'hide' targeting element by detaching it - then we get some unexpected errors (like in #4390 )
@sculpt0r sculpt0r added the type:feature A feature request. label Dec 31, 2020
@sculpt0r sculpt0r mentioned this issue Dec 31, 2020
Closed
@sculpt0r sculpt0r added status:confirmed An issue confirmed by the development team. core The issue is caused by the editor core code. labels Dec 31, 2020
@sculpt0r sculpt0r self-assigned this Dec 31, 2020
@sculpt0r sculpt0r mentioned this issue Dec 31, 2020
Merged
3 tasks
@sculpt0r sculpt0r added size:S and removed size:M labels Jan 4, 2021
@sculpt0r sculpt0r mentioned this issue Jan 7, 2021
Closed
@f1ames f1ames mentioned this issue Feb 4, 2021
Open
@Dumluregn Dumluregn mentioned this issue Mar 3, 2021
Closed
@f1ames f1ames added size:M and removed size:S labels Mar 29, 2021
@f1ames f1ames added size:S and removed size:M labels Apr 9, 2021
@f1ames f1ames mentioned this issue Apr 20, 2021
Merged
3 tasks
@CKEditorBot
Copy link
Collaborator

Closed in #4463

@CKEditorBot CKEditorBot added this to the 4.17.0 milestone Apr 23, 2021
@Dumluregn Dumluregn mentioned this issue May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculpt0r sculpt0r

Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.17.0
Development

Successfully merging a pull request may close this issue.

Prevent editor creation on detached element ckeditor/ckeditor4
3 participants
@f1ames @sculpt0r @CKEditorBot