Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for block quotes #2371

Closed
Reinmar opened this issue May 5, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-autoformat#28
Closed

Add support for block quotes #2371

Reinmar opened this issue May 5, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-autoformat#28
Labels
package:autoformat type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented May 5, 2017

"> " should start a quote.

@fredck
Copy link
Contributor

fredck commented May 5, 2017

Shouldn't this be available for the "Quoted Text" feature only, which is still not implemented?

@Reinmar
Copy link
Member Author

Reinmar commented May 5, 2017

What's "Quoted Text"? Do you mean pulled quotes?

@fredck
Copy link
Contributor

fredck commented May 5, 2017

No, there are 3 quote related features:

  • "Block Quote" - quoting a third party in an article.
  • "Pull Quote" - a quote that is a repetition of a small piece of text from the same article.
  • "Quoted Text" - quoting original text when giving a reply, like an e-mail or GH tickets.

AFAIK, we have "Block Quote" implemented so far. I believe that the common practice of using > fits only the "Quoted Text" case.

@Reinmar
Copy link
Member Author

Reinmar commented May 5, 2017

OK, I got confused y all these names... :D

So... I don't know. I think that the users may be using "> " for both things. And there should be no problem with having autoformatter applying the QT if present or BQ if not.

But I'm also unsure which should have precedence. QT, as you mentioned many times yourself, is done programmatically – by your system when you reply to some message. You can also be doing it manually when copy+pasting some message into your editor. You may, actually, be doing BQ manually more often.

Still, the main point is that BQ and QT will rarely be used together so there's no big issue with having both of them applied on "> ", depending on which is loaded.

@szymonkups szymonkups self-assigned this May 16, 2017
oleq referenced this issue in ckeditor/ckeditor5-autoformat May 18, 2017
Feature: Block quote support. Closes #26.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-autoformat Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:autoformat labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:autoformat type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants