Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers written in a paragraph are wrongly changed to a Numbered list after a blank space is added #2382

Closed
vladikoff opened this issue Nov 22, 2017 · 4 comments · Fixed by ckeditor/ckeditor5-autoformat#43
Labels
package:autoformat type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@vladikoff
Copy link

Original bug: mozilla/notes#429
Codepen Link for easy testing: https://codepen.io/vladikoff/pen/vWjGPe

I used the editor with GFM enabled from: https://github.com/szymonkups/ckeditor5-build-classic/tree/markdown_support

STR

  • Enable Markdown GFM plugin
  • Type a new line and type a number plus a space (example: 25 cakes)

Expected

The string should remain as 25 cakes

Actual

The 25 is converted to a 1. (markdown numbered list)

Details

I think Markdown numbered list should only activate if I type 1. (one plus a dot plus a space), but I might be wrong.

gfm2


vladikoff referenced this issue in vladikoff/ckeditor5-autoformat Nov 22, 2017
@Reinmar
Copy link
Member

Reinmar commented Nov 22, 2017

I agree with both – that "." or ")" should be enforced (I actually thought it is) and that supporting only /1[\.)]/ makes sense since CKEditor 5 doesn't support the start attribute yet anyway.

@scofalik
Copy link
Contributor

I also agree that this is a valid issue.

@vladikoff
Copy link
Author

PR here: ckeditor/ckeditor5-autoformat#43

@Reinmar
Copy link
Member

Reinmar commented Nov 30, 2017

@szymonkups pointed out that it makes sense to support 1-9 because there are situations when you might write a different number than 1.

szymonkups referenced this issue in ckeditor/ckeditor5-autoformat Dec 1, 2017
Fix: Ordered list will now be triggered by a numer and `.` or `)`. Closes #42.

Thanks to @vladikoff!
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-autoformat Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:autoformat labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:autoformat type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants