From 0027f2a6a773c148c4aa6f3d554d3ac3929deb54 Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Tue, 7 Nov 2017 17:18:20 +0100 Subject: [PATCH 1/2] Migrated UI components from SASS to PostCSS. Added theme support. --- src/blockquote.js | 3 +-- theme/blockquote.css | 8 ++++++++ theme/theme.scss | 11 ----------- 3 files changed, 9 insertions(+), 13 deletions(-) create mode 100644 theme/blockquote.css delete mode 100644 theme/theme.scss diff --git a/src/blockquote.js b/src/blockquote.js index e0b85d5..cd75e62 100644 --- a/src/blockquote.js +++ b/src/blockquote.js @@ -9,11 +9,10 @@ import Plugin from '@ckeditor/ckeditor5-core/src/plugin'; import BlockQuoteEngine from './blockquoteengine'; - import ButtonView from '@ckeditor/ckeditor5-ui/src/button/buttonview'; import quoteIcon from '@ckeditor/ckeditor5-core/theme/icons/quote.svg'; -import '../theme/theme.scss'; +import '../theme/blockquote.css'; /** * The block quote plugin. diff --git a/theme/blockquote.css b/theme/blockquote.css new file mode 100644 index 0000000..457ede7 --- /dev/null +++ b/theme/blockquote.css @@ -0,0 +1,8 @@ +/** + * @license Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved. + * For licensing, see LICENSE.md. + */ + +blockquote { + overflow: hidden; +} diff --git a/theme/theme.scss b/theme/theme.scss deleted file mode 100644 index 891e9fd..0000000 --- a/theme/theme.scss +++ /dev/null @@ -1,11 +0,0 @@ -// Copyright (c) 2003-2017, CKSource - Frederico Knabben. All rights reserved. -// For licensing, see LICENSE.md or http://ckeditor.com/license - -blockquote { - border-left: solid 5px #CCC; - padding-left: 20px; - margin-left: 0; - font-style: italic; - // See #12. - overflow: hidden; -} From 49fdb4269e4c0c0acdfb56817050e2260651dc4a Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Wed, 29 Nov 2017 17:07:38 +0100 Subject: [PATCH 2/2] Added missing comment to the package styles sheet. --- theme/blockquote.css | 1 + 1 file changed, 1 insertion(+) diff --git a/theme/blockquote.css b/theme/blockquote.css index 457ede7..ca8149c 100644 --- a/theme/blockquote.css +++ b/theme/blockquote.css @@ -4,5 +4,6 @@ */ blockquote { + /* See #12 */ overflow: hidden; }