From 4af60d77ae0e76a2fff799b70e664f68e5764dc1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Wed, 16 Jan 2019 16:30:07 +0100 Subject: [PATCH 1/2] Add memory leak test. --- tests/ckeditor.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tests/ckeditor.js b/tests/ckeditor.js index cccd471ace..c86903517e 100644 --- a/tests/ckeditor.js +++ b/tests/ckeditor.js @@ -7,6 +7,7 @@ import DecoupledEditor from '../src/ckeditor'; import BaseDecoupledEditor from '@ckeditor/ckeditor5-editor-decoupled/src/decouplededitor'; +import { describeMemoryUsage, testMemoryUsage } from '@ckeditor/ckeditor5-core/tests/_utils/memory'; describe( 'DecoupledEditor build', () => { let editor, editorData, editorElement; @@ -25,7 +26,7 @@ describe( 'DecoupledEditor build', () => { editor = null; } ); - describe( 'buid', () => { + describe( 'build', () => { it( 'contains plugins', () => { expect( DecoupledEditor.builtinPlugins ).to.not.be.empty; } ); @@ -59,6 +60,12 @@ describe( 'DecoupledEditor build', () => { } ); } ); + describeMemoryUsage( () => { + testMemoryUsage( + 'should not grow on multiple create/destroy', + () => DecoupledEditor.create( document.querySelector( '#mem-editor' ) ) ); + } ); + function test( getEditorDataOrElement ) { describe( 'create()', () => { beforeEach( () => { From 87b70fa4d7fb2780208657054d7702bc72b25b89 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Tue, 22 Jan 2019 10:35:55 +0100 Subject: [PATCH 2/2] Add missing ckeditor5-core dependency. --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 083c74b9f6..67d8a0a0de 100644 --- a/package.json +++ b/package.json @@ -31,6 +31,7 @@ "@ckeditor/ckeditor5-basic-styles": "^10.1.0", "@ckeditor/ckeditor5-block-quote": "^10.1.1", "@ckeditor/ckeditor5-ckfinder": "^10.0.0", + "@ckeditor/ckeditor5-core": "^11.1.0", "@ckeditor/ckeditor5-dev-utils": "^11.0.1", "@ckeditor/ckeditor5-dev-webpack-plugin": "^7.0.1", "@ckeditor/ckeditor5-easy-image": "^10.0.4",