From ae8f9f398d506b411757131d0d73cd58a0eaa8fa Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Mon, 18 Nov 2019 15:46:57 +0100 Subject: [PATCH 1/2] Docs: Added documentation for the config.toolbar.shouldGroupWhenFull option. --- src/editor/editorconfig.jsdoc | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/editor/editorconfig.jsdoc b/src/editor/editorconfig.jsdoc index f4e7a3f0..88ff3903 100644 --- a/src/editor/editorconfig.jsdoc +++ b/src/editor/editorconfig.jsdoc @@ -144,7 +144,9 @@ * toolbar: { * items: [ 'bold', 'italic', '|', 'undo', 'redo' ], * - * viewportTopOffset: 30 + * viewportTopOffset: 30, + * + * shouldGroupWhenFull: true * } * }; * @@ -162,6 +164,11 @@ * * **`toolbar.viewportTopOffset`** – The offset (in pixels) from the top of the viewport used when positioning a sticky toolbar. * Useful when a page with which the editor is being integrated has some other sticky or fixed elements * (e.g. the top menu). Thanks to setting the toolbar offset the toolbar will not be positioned underneath or above the page's UI. + * * **`toolbar.shouldGroupWhenFull`** – When `true` (default), the toolbar will group its items that + * would normally wrap to the next line when there is not enough space to display them in a single row. + * + * **Note**: For now this option works for {@link module:editor-classic/classiceditor~ClassicEditor} and + * {@link module:editor-decoupled/decouplededitor~DecoupledEditor} only. * * @member {Array.|Object} module:core/editor/editorconfig~EditorConfig#toolbar */ From ee2b5eedfc6f6cf57af3ec0ae669330daaa414fc Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Tue, 19 Nov 2019 13:56:29 +0100 Subject: [PATCH 2/2] Renamed config.toolbar.shouldGroupWhenFull to config.toolbar.shouldNotGroupWhenFull. --- src/editor/editorconfig.jsdoc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/editor/editorconfig.jsdoc b/src/editor/editorconfig.jsdoc index 88ff3903..ca45e6e6 100644 --- a/src/editor/editorconfig.jsdoc +++ b/src/editor/editorconfig.jsdoc @@ -146,7 +146,7 @@ * * viewportTopOffset: 30, * - * shouldGroupWhenFull: true + * shouldNotGroupWhenFull: true * } * }; * @@ -164,11 +164,11 @@ * * **`toolbar.viewportTopOffset`** – The offset (in pixels) from the top of the viewport used when positioning a sticky toolbar. * Useful when a page with which the editor is being integrated has some other sticky or fixed elements * (e.g. the top menu). Thanks to setting the toolbar offset the toolbar will not be positioned underneath or above the page's UI. - * * **`toolbar.shouldGroupWhenFull`** – When `true` (default), the toolbar will group its items that - * would normally wrap to the next line when there is not enough space to display them in a single row. + * * **`toolbar.shouldNotGroupWhenFull`** – When set `true`, the toolbar will stop grouping items that wrap to the next line when + * there is not enough space to display them in a single row. * - * **Note**: For now this option works for {@link module:editor-classic/classiceditor~ClassicEditor} and - * {@link module:editor-decoupled/decouplededitor~DecoupledEditor} only. + * **Note**: For now this option affects {@link module:editor-classic/classiceditor~ClassicEditor} and + * {@link module:editor-decoupled/decouplededitor~DecoupledEditor} only that enable automatic toolbar items grouping by default. * * @member {Array.|Object} module:core/editor/editorconfig~EditorConfig#toolbar */