-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust releasing tools to work with monorepo #7205
Comments
A question: how to specify new versions of the packages? Now they are gathered from changelogs. If we will have a single changelog, it can be a little harder. Or maybe not but we don't know how the changelog will look. |
Estimated blindly at 5 points, we still need to clarify our requirements. |
I think we should embrace the chance to reshape the changelog. I would see following changes:
I agree with this quote from keep a changelog initiative:
So legibility is important and we should avoid redundant text, or script-friendly lists. A proposal is format like the following:
In case there are changes that affect (almost) all packages we could use Our current approach of picking initial changelog values from commit messages seem to work fine. |
There is a problem with builds. As for now, we are using npm prehooks for building fresh versions. The release tool at some point calls: exec( `npm version ${ releaseDetails.version } --message "Release: v${ releaseDetails.version }. [skip ci]"` ); for every repository (in proper directory). It means, the After switching to one repository, calling this command will produce 5 the same commits. The preversion hook looks like: {
"preversion": "npm run build; if [ -n \"$(git status src/ckeditor.js build/ --porcelain)\" ]; then git add -u src/ckeditor.js build/ && git commit -m 'Internal: Build.'; fi"
} Instead, we could remove "committing option" from the hooks (just call the build command) and commit everything after bumping version |
Yup, it make sense to make just one commit. So |
On the i/606 branch I've just pushed the adjusted version of release tools. Release tools handle monorepo now. They also work with single repo (integrations). |
Other (ckeditor5): Adjusted release tools to handle single mono-repository architecture. Closes #606. MAJOR BREAKING CHANGE: CKEditor 5 release tools now are designed to work with monorepo architecture.
Subissue of #6466.
Requires: https://github.com/ckeditor/ckeditor5-dev/issues/608.
The text was updated successfully, but these errors were encountered: