Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to set data in constructor instead of element #2342

Closed
szymonkups opened this issue May 14, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-editor-balloon#19
Closed

Allow to set data in constructor instead of element #2342

szymonkups opened this issue May 14, 2018 · 0 comments · Fixed by ckeditor/ckeditor5-editor-balloon#19
Assignees
@pomek
Labels
package:editor-balloon type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 19

Comments

@szymonkups
Copy link
Contributor

There should be a possibility to initialize editor with data passed to the constructor instead of the element to replace. Part of https://github.com/ckeditor/ckeditor5-core/issues/64. The editor should create its own element and return it in editor.element filed.
@szymonkups szymonkups self-assigned this May 14, 2018
@Reinmar Reinmar assigned pomek and unassigned szymonkups Jun 8, 2018
Reinmar referenced this issue in ckeditor/ckeditor5-editor-balloon Jul 3, 2018
@Reinmar
Merge pull request #19 from ckeditor/t/18
48c265c 
Feature: Editor can now be created with initial data passed to the `create()` method. Closes #18.

BREAKING CHANGE: The `BalloonEditor#element` property was renamed to `BalloonEditor#sourceElement`
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-editor-balloon Oct 9, 2019
@mlewand mlewand added this to the iteration 19 milestone Oct 9, 2019
@mlewand mlewand added type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:editor-balloon labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pomek pomek

Labels
package:editor-balloon type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 19
Development

Successfully merging a pull request may close this issue.

Allow to pass initial data to the editor constructor ckeditor/ckeditor5-editor-balloon
3 participants
@pomek @szymonkups @mlewand