Merge pull request #54 from ckeditor/t/53

Fix: It should be possible to use `ClassicEditor.create()` in its child classes. Closes #53.
ckeditor · Mar 21, 2017 · 95798ba · 95798ba
2 parents b3c066c + cc416bc
commit 95798ba
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/classic.js b/src/classic.js
@@ -81,7 +81,7 @@ export default class ClassicEditor extends StandardEditor {
 	 */
 	static create( element, config ) {
 		return new Promise( ( resolve ) => {
-			const editor = new ClassicEditor( element, config );
+			const editor = new this( element, config );
 
 			resolve(
 				editor.initPlugins()

diff --git a/tests/classic.js b/tests/classic.js
@@ -87,6 +87,22 @@ describe( 'ClassicEditor', () => {
 		it( 'loads data from the editor element', () => {
 			expect( editor.getData() ).to.equal( '<p><strong>foo</strong> bar</p>' );
 		} );
+
+		it( 'creates an instance of a ClassicEditor child class', () => {
+			class CustomClassicEditor extends ClassicEditor {}
+
+			return CustomClassicEditor.create( editorElement, {
+					plugins: [ Paragraph, Bold ]
+				} )
+				.then( newEditor => {
+					editor = newEditor;
+
+					expect( newEditor ).to.be.instanceof( CustomClassicEditor );
+					expect( newEditor ).to.be.instanceof( ClassicEditor );
+
+					expect( newEditor.getData() ).to.equal( '<p><strong>foo</strong> bar</p>' );
+				} );
+		} );
 	} );
 
 	describe( 'create - events', () => {