Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd things start to happen after correcting a word and undo/redo #4187

Closed
Reinmar opened this issue Sep 29, 2017 · 1 comment
Closed

Odd things start to happen after correcting a word and undo/redo #4187

Reinmar opened this issue Sep 29, 2017 · 1 comment
Assignees
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Reinmar
Copy link
Member

Reinmar commented Sep 29, 2017

sep-29-2017 17-39-38

Sometimes it replaces the wrong letters. Sometimes it crashes completely (nodelist-out-of-bounds error). Sometimes you get this:

sep-29-2017 17-42-40

@Reinmar Reinmar assigned Reinmar and scofalik and unassigned Reinmar Sep 29, 2017
@scofalik
Copy link
Contributor

scofalik commented Oct 2, 2017

It's weird because these are just normal operations that works with undo as any other operations. Maybe something breaks when there is insert and remove/move in one batch?

EDIT: Seems like spellchecker generates "empty" insert operation: Applying InsertOperation( 2 ): # -> main [ 0, 17 ]

Reinmar referenced this issue in ckeditor/ckeditor5-typing Oct 2, 2017
Fix: Fixed a bug where using spellchecker sometimes caused creating incorrect deltas, which caused bugs in undo. Closes #123. Closes ckeditor/ckeditor5-engine#1152.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 12 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants