Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up model change events #4219

Closed
pjasiun opened this issue Dec 19, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1216
Closed

Clean-up model change events #4219

pjasiun opened this issue Dec 19, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1216
Assignees
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@pjasiun
Copy link

pjasiun commented Dec 19, 2017

After introducing differ we need to clean-up events model and document fire.

  1. Current change and changesDone events should be removed.
  2. API to add postfixers should be added (see prototype here) and all change listeners which are post fixers should be changed to post-fixers.
  3. New document.change event should be introduced, which should be fired after all changes related to the single batch are done. Changes which are executed on the separate batch (i.e. autoformatter) should listen on this event and do enqueueChange().
  4. Listeners which really need to listen on each operation apply (live positions, differ) should now listen on applyOperation.
  5. We should consider removing data object which is returned by the operation execute, or change it. It made sense when the change event was fired base on the operation applied, but now it might not be needed anymore.
  6. model.change event should be private (model._change), is should be used only by the document to fire document.change.
pjasiun referenced this issue in ckeditor/ckeditor5-engine Jan 11, 2018
Other: Refactored events fired by model classes. Closes #1207.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 14 milestone Oct 9, 2019
@mlewand mlewand added module:model type:improvement This issue reports a possible enhancement of an existing feature. package:engine labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants