Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The upcast element to attribute fails to convert when upcastAlso is defined as a function #4534

Closed
jodator opened this issue Aug 29, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1787
Closed

The upcast element to attribute fails to convert when upcastAlso is defined as a function #4534

jodator opened this issue Aug 29, 2019 · 0 comments · Fixed by ckeditor/ckeditor5-engine#1787
Assignees
@jodator
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 27 (v15...

Comments

@jodator
Copy link
Contributor

jodator commented Aug 29, 2019

Found out after ckeditor/ckeditor5-basic-styles#94 got merged. The prepareToAttribute() converter exits when in a config.view only a name of an element was defined. That check didn't account for the possibility of a function being provided. This would wrongly mark such definitions as with an only name defined and wasn't converting an attribute properly.

This fix is simple and only needs some tests to be written.
@jodator jodator self-assigned this Aug 29, 2019
mlewand referenced this issue in ckeditor/ckeditor5-engine Aug 29, 2019
@mlewand
Fix: Added a proper check for name-only view matcher in attribute upc…
2210696 
…ast converters. Closes #1786.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-engine Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:engine labels Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodator jodator

Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 27 (v15.0.0)
2 participants
@jodator @mlewand