-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrapping text into attribute causes error #3753
Closed
Labels
Milestone
Comments
oskarwrobel
referenced
this issue
in ckeditor/ckeditor5-engine
Jun 8, 2016
This was caused by the ugly bug in the typing feature: ckeditor/ckeditor5-typing@9c08e05 (quick fix). In fact these are two ugly bugs. |
Is this on review or something? |
Nope. I was creating hackaton-independent manual test to check if the typing fixes are enough to solve this issue and I found more problems, so I keep working on it. |
pjasiun
referenced
this issue
in ckeditor/ckeditor5-engine
Jun 21, 2016
pjasiun
changed the title
Converting Model to AttributeElement converts more than it should
Wrapping text into attribute causes error
Jun 22, 2016
szymonkups
referenced
this issue
in ckeditor/ckeditor5-engine
Feb 2, 2018
oskarwrobel
referenced
this issue
in ckeditor/ckeditor5-engine
Feb 6, 2018
Other: Manual test for #475 now works correctly. Closes #1271.
mlewand
added
type:bug
This issue reports a buggy (incorrect) behavior.
package:engine
labels
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I was working on auto linking I had a problem with converting model nodes with
link
attribute toAttributeElement
After changing
AttributeElement
to element with no attributeseverything looks fine (I've used
b
tag instead ofa
but it works exactly the same):On branch ckeditor5-engine#t/475-example is a code example:
https://github.com/ckeditor/ckeditor5-engine/tree/t/475-example/src/t-475
And manual test:
https://github.com/ckeditor/ckeditor5-engine/blob/t/475-example/tests/manual/t-475.js
http://localhost:1030/build/amd/tests/engine/manual/t-475
The text was updated successfully, but these errors were encountered: