Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaulBlockName and make EnterCommand extendable #4555

Closed
scofalik opened this issue Sep 13, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-enter#28
Closed

Remove defaulBlockName and make EnterCommand extendable #4555

scofalik opened this issue Sep 13, 2016 · 0 comments · Fixed by ckeditor/ckeditor5-enter#28
Assignees
@scofalik
Labels
package:enter type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 3

Comments

@scofalik
Copy link
Contributor

defaultBlockName behavior is not something usual for EnterCommand execution and it should be removed. On the other hand, to enable special case scenarios for EnterCommand, it should become extendable. This will be done by firing an event after the command is executed.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-enter Oct 9, 2019
@mlewand mlewand added this to the iteration 3 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:enter labels Oct 9, 2019
@scofalik scofalik mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scofalik scofalik

Labels
package:enter type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 3
Development

Successfully merging a pull request may close this issue.

T/27 ckeditor/ckeditor5-enter
2 participants
@scofalik @mlewand